From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 11 Aug 2022 16:22:22 +0000 (+0200)
Subject: BUG/MEDIUM: mux-quic: fix crash due to invalid trace arg
X-Git-Tag: v2.7-dev4~52
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6bdf9367fbf2ea51fce693d8013cb46de8af2df0;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: mux-quic: fix crash due to invalid trace arg

Traces argument were incorrectly used in qcs_free(). A qcs was specified
as first arg instead of a connection. This will lead to a crash if
developer qmux traces are activated. This is now fixed.

This bug has been introduced with QUIC MUX traces rework. No need to
backport.
---

diff --git a/src/mux_quic.c b/src/mux_quic.c
index 0e3a54d044..196f682c23 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -229,7 +229,7 @@ static void qc_free_ncbuf(struct qcs *qcs, struct ncbuf *ncbuf)
  */
 static void qcs_free(struct qcs *qcs)
 {
-	TRACE_ENTER(QMUX_EV_QCS_END, qcs);
+	TRACE_ENTER(QMUX_EV_QCS_END, qcs->qcc->conn, qcs);
 
 	qc_free_ncbuf(qcs, &qcs->rx.ncbuf);
 	b_free(&qcs->tx.buf);