From: drh <> Date: Fri, 13 Jun 2025 00:50:14 +0000 (+0000) Subject: Change the flex-search EQP message to be "SEARCH ... OR SCAN" as this seems X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6bf192bf08022bb3858379f6d394eadd266a32e7;p=thirdparty%2Fsqlite.git Change the flex-search EQP message to be "SEARCH ... OR SCAN" as this seems less disruptive and more readable. FossilOrigin-Name: 680e278c3e15d3d2c2e7826bdc8fdf0b5e2086cda0a441fffb13acf9103721a0 --- diff --git a/ext/expert/expert1.test b/ext/expert/expert1.test index a6e357930f..e89b7be575 100644 --- a/ext/expert/expert1.test +++ b/ext/expert/expert1.test @@ -77,7 +77,7 @@ foreach {tn setup} { $expert destroy set tst [subst -nocommands {set {} [squish [join {$result}]]}] - set tst [string map {{FLEX-SEARCH} SEARCH} $tst] + set tst [string map {{ OR SCAN} {}} $tst] uplevel [list do_test $tn $tst [string trim [squish $res]]] } } @@ -91,7 +91,7 @@ foreach {tn setup} { proc do_rec_test {tn sql res} { set res [squish [string trim $res]] set tst [subst -nocommands { - string map {{FLEX-SEARCH} SEARCH} [squish [string trim [exec $::CLI test.db ".expert" {$sql;}]]] + string map {{ OR SCAN} {}} [squish [string trim [exec $::CLI test.db ".expert" {$sql;}]]] }] uplevel [list do_test $tn $tst $res] } diff --git a/manifest b/manifest index 7b1d8386de..53b88ae081 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Fix\stest\scases\son\sthe\sexpert\sextension. -D 2025-06-13T00:25:01.521 +C Change\sthe\sflex-search\sEQP\smessage\sto\sbe\s"SEARCH\s...\sOR\sSCAN"\sas\sthis\sseems\nless\sdisruptive\sand\smore\sreadable. +D 2025-06-13T00:50:14.385 F .fossil-settings/binary-glob 61195414528fb3ea9693577e1980230d78a1f8b0a54c78cf1b9b24d0a409ed6a x F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea @@ -71,7 +71,7 @@ F doc/wal-lock.md 7db0cd61e2000b545b78ce89b0c2a9a8dd8d64c097839258ac10d7c5c4156e F ext/README.md 6eb1ac267d917767952ed0ef63f55de003b6a5da433ce1fa389e1a9532e73132 F ext/expert/README.md b321c2762bb93c18ea102d5a5f7753a4b8bac646cb392b3b437f633caf2020c3 F ext/expert/expert.c d548d603a4cc9e61f446cc179c120c6713511c413f82a4a32b1e1e69d3f086a4 -F ext/expert/expert1.test b753c50cbb37da2b863f26ac5f8cc031f523ea3bc113af389c7d79fb62522f7b +F ext/expert/expert1.test cb17a345a3c24310622fbf743fb0e23fa04503f4ea1891b08412f80d87370dfe F ext/expert/sqlite3expert.c cf4b1e5584862f486a4c6014ddb081831f1c512065dcf35644638d57179979d6 F ext/expert/sqlite3expert.h ca81efc2679a92373a13a3e76a6138d0310e32be53d6c3bfaedabd158ea8969b F ext/expert/test_expert.c c395134bd6d4efa594a7d26578a1cb624c4027b79b4b5fcd44736c5ef1f5f725 @@ -869,7 +869,7 @@ F src/wal.h ba252daaa94f889f4b2c17c027e823d9be47ce39da1d3799886bbd51f0490452 F src/walker.c d5006d6b005e4ea7302ad390957a8d41ed83faa177e412f89bc5600a7462a014 F src/where.c 1a663cfc00974dec3e37e378f407ffc5a6ce0c06506b8b7ea27c1fc592746f0e F src/whereInt.h b0c5487551dc7821426cac213fd5c194a558cab9dfd4e130d71f7afa6416463c -F src/wherecode.c e1e64cd05bbc0381c1c08c354853ea6d3d7cb468641e86ee5e803168d114df0d +F src/wherecode.c 3f7bcdf22c0ee63d778cfd7a23c4c97ffb1574e2e8047c7ef53e3722eb0155d5 F src/whereexpr.c 2415c8eee5ff89a8b709d7d83d71c1ff986cd720d0520057e1d8a5371339012a F src/window.c d01227141f622f24fbe36ca105fbe6ef023f9fd98f1ccd65da95f88886565db5 F test/8_3_names.test ebbb5cd36741350040fd28b432ceadf495be25b2 @@ -932,7 +932,7 @@ F test/autoanalyze1.test b9cc3f32a990fa56669b668d237c6d53e983554ae80c0604992e188 F test/autoinc.test 9df9930966dbe92c55ef37a4d89112cfd537be0d0596d397177c12db9e581be0 F test/autoindex1.test 65931519206bbec71948b11e125af0656435a0937973fe5fed70d776a712911f F test/autoindex2.test 12ef578928102baaa0dc23ad397601a2f4ecb0df -F test/autoindex3.test 4d0a7a412622eb70a8901d8dbac6dc806f71ec8b80c1a0ea0593c4218e95e8dc +F test/autoindex3.test 5ac57438d9d83d13c0302a28e40dfa0df0886905c4207883a60c67516ce2791f F test/autoindex4.test 3c2105e9172920e26f950ba3c5823e4972190e022c1e6f260ba476b0af24c593 F test/autoindex5.test 3fb938cbf4e7f3896563ce04e2a24b0bc653fc6245b4bf3268cd7b20f441d87f F test/autovacuum.test 00671369bbf96c6a49989a9425f5b78b94075d6a4b031e5e00000c2c32f365df @@ -1051,7 +1051,7 @@ F test/corruptK.test ac13504593d89d69690d45479547616ed12644d42b5cb7eeb2e759a76fc F test/corruptL.test 652fc8ac0763a6fd3eb28b951d481924167b2d9936083bcc68253b2274a0c8fe F test/corruptM.test 7d574320e08c1b36caa3e47262061f186367d593a7e305d35f15289cc2c3e067 F test/corruptN.test a034bb217bebd8d007625dfb078e76ec3d53515052dbceb68bd47b2c27674d5c -F test/cost.test 8babd06a35d68f67032b44603c55e95271dd58511d6f50f167c9a8012fba8f80 +F test/cost.test 280e7b7f9f6b0b5558ae3c3ab91f5d22f9b63999c12f03bb1799173158d36904 F test/count.test cd4bd531066e8d77ef8fe1e3fc8253d042072e117ccab214b290cf83f1602249 F test/countofview.test 4088e461a10ee33e69803c177a69aa1d7bba81a9ffc2df66d76465a22ca7fdfc F test/coveridxscan.test f35c7208dedc4f98e471c569df64c0f95a49f6e072d8dc7c8f99bdee2697de1b @@ -1405,7 +1405,7 @@ F test/laststmtchanges.test ae613f53819206b3222771828d024154d51db200 F test/lemon-test01.y 70110eff607ab137ccc851edb2bc7e14a6d4f246b5d2d25f82a60b69d87a9ff2 F test/like.test 0036f8fe548fceabd1496361bfa262f35cf5ed17c794bd15e22e9f3de12e0eb0 F test/like2.test d3be15fefee3e02fc88942a9b98f26c5339bbdef7783c90023c092c4955fe3d3 -F test/like3.test fa69e88f4a66aefa005fcc6c8b3b7e5531e12cad9b24bebb6241d6e5e5e54117 +F test/like3.test 86ffc7b04f18a914592f605150c88b9e0da32067684ba38a7fe71f19135c1b49 F test/limit.test 350f5d03c29e7dff9a2cde016f84f8d368d40bcd02fa2b2a52fa10c4bf3cbfaf F test/limit2.test 621188fc3e5c3b8d2ef9827e05fa8313792ae563579073136efd25cb65325f1b F test/literal.test a65dca9fef86e51b8e45544268e37abbd4bb94ba35fd65f6fdcab2f288cd8f79 @@ -1694,7 +1694,7 @@ F test/spellfix4.test 51c7c26514ade169855c66bcf130bd5acfb4d7fd090cc624645ab275ae F test/sqldiff1.test 1b7ab4f312442c5cc6b3a5f299fa8ca051416d1dd173cb1126fd51bf64f2c3fb F test/sqllimits1.test 408131e4975d61868711c83f101a56d4602313cc5cae88d3eee81c1da364fd89 F test/sqllog.test 6af6cb0b09f4e44e1917e06ce85be7670302517a -F test/starschema1.test f5388cd32527ab18d3f98f9e3402ec780f6a186e04e0d9c8531d7568ee734e11 +F test/starschema1.test d3b22a6eef7a61d24e5f7beb531aa54554355fe72566df7cbe729be179ea13c4 F test/startup.c 1beb5ca66fcc0fce95c3444db9d1674f90fc605499a574ae2434dcfc10d22805 F test/stat.test 123212a20ceb496893d5254a5f6c76442ce549fdc08d1702d8288a2bbaac8408 F test/statfault.test 064f43379e4992b5221b7d9ac887c313b3191f85cce605d78e416fc4045da64e @@ -1895,7 +1895,7 @@ F test/tkt3992.test f3e7d548ac26f763b47bc0f750da3d03c81071da F test/tkt3997.test a335fa41ca3985660a139df7b734a26ef53284bd F test/tkt4018.test 18dbc6617f7a4b90e938d1bd6d26ad18daafaf08 F test/tokenize.test ce430a7aed48fc98301611429595883fdfcab5d7 -F test/tpch01.test 35b799a0c75693eb581ed0f58ce9d4ebe6e397f8b90945b2307a973c5fe5f880 +F test/tpch01.test 4dd988585c85823bb1037215f2689408186fba85579144ac413bcccda218c10a F test/trace.test a659a9862957f4789e37a92b3bf6d2caf5c86b02cdeefc41e850ae53acf6992a F test/trace2.test f5cb67ad3bc09e0c58e8cca78dfd0b5639259983 F test/trace3.test 2deeac66359c9f007f0fc9fb6336994a5d68fc1a65129f322a9e9546fd537d0a @@ -2063,12 +2063,12 @@ F test/whereJ.test fc05e374cc9f2dc204148d6c06822c380ad388895fe97a6d335b94a26a08a F test/whereK.test 0270ab7f04ba5436fb9156d31d642a1c82727f4c4bfe5ba90d435c78cf44684a F test/whereL.test cb115604cc9bd61acbc99a1f1df0eb1ea7a7875a77fef25ba9282f01d10283e1 F test/whereM.test 0dbc9998783458ddcf3cc078ca7c2951d8b2677d472ecf0028f449ed327c0250 -F test/whereN.test 025327fc8d756a881dbd7ff20b3180adff8fb1576d0b60ee0b3d764519af78c2 +F test/whereN.test 257fd00052b7973a105fd80ed362d4026e24d0027626385c5cd2808c06f2c66b F test/wherefault.test 6cf2a9c5712952d463d3f45ebee7f6caf400984df51a195d884cfb7eb0e837a7 F test/wherelfault.test 9012e4ef5259058b771606616bd007af5d154e64cc25fa9fd4170f6411db44e3 F test/wherelimit.test afb46397c6d7e964e6e294ba3569864a0c570fe3807afc634236c2b752372f31 F test/wherelimit2.test b9e4bfe7b4d7c2f85f99cf2bd2c51369378d04b1f3d1b60557423752003bfd90 -F test/wherelimit3.test b856e699769cb904af7a3e7b2bd32e28f828902acb13517956fcfc81377f0826 +F test/wherelimit3.test 207afe1790f28a67b16a8e4e947dd97fef4883ae7c7536860eae739994da2372 F test/widetab1.test c296a98e123762de79917350e45fa33fdf88577a2571eb3a64c8bf7e44ef74d1 F test/win32heap.test 1ec2ce646aee491ec23bfcdfd005b33c79f13bf91467966f374a76ffe7c7e85f F test/win32lock.test e56d7a9b6cf9d5f3867c2dd19ff36c5326881e4038c6867610ecb3a9868ea4eb @@ -2099,7 +2099,7 @@ F test/windowfault.test 15094c1529424e62f798bc679e3fe9dfab6e8ba2f7dfe8c923b6248c F test/windowpushd.test c420e2265f0e09a0e798d0513a660d71b51602088d81b3dbd038918ee1339dcc F test/with1.test 1ee171d7c306ab8b0771f3511d870f56c735607729836585bbceb1fc2f47e0b1 F test/with2.test 181674a6cc86a601ca2ac052741cdfad5b529e07e870435d2f6cdb92d589ff17 -F test/with3.test a39c0003d6e6d8bfff3461f66a1d53edab04715e309a303e17b2065837ef9f25 +F test/with3.test e0e9d2a866a09ac50f995bacb97aa26f6f34100c351de0c18d671f70188d78d0 F test/with4.test 257be66c0c67fee1defbbac0f685c3465e2cad037f21ce65f23f86084f198205 F test/with5.test 6248213c41fab36290b5b73aa3f937309dfba337004d9d8434c3fabc8c7d4be8 F test/with6.test 281e4861b5e517f6c3c2f08517a520c1e2ee7c11966545d3901f258a4fe8ef76 @@ -2208,8 +2208,8 @@ F tool/version-info.c 3b36468a90faf1bbd59c65fd0eb66522d9f941eedd364fabccd7227350 F tool/warnings-clang.sh bbf6a1e685e534c92ec2bfba5b1745f34fb6f0bc2a362850723a9ee87c1b31a7 F tool/warnings.sh 1ad0169b022b280bcaaf94a7fa231591be96b514230ab5c98fbf15cd7df842dd F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f -P 521948c64fc7a043e891e4dc3255bd59a76332c58b34d81057eecdf2fef31a63 -R 8e88dd6a43a25efd7e3b9bd889289e51 +P c46feb36b50d6128177caac346d62643a499a5dbd9d228e225fc4be4bf058240 +R bf857c9695965d4977782542a6373cbe U drh -Z d1c6d043de1f71e24c9ca9590d378de8 +Z e773f51d22b7f7744e30e9929763f944 # Remove this line to create a well-formed Fossil manifest. diff --git a/manifest.uuid b/manifest.uuid index 69db5847d7..61924a0095 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -c46feb36b50d6128177caac346d62643a499a5dbd9d228e225fc4be4bf058240 +680e278c3e15d3d2c2e7826bdc8fdf0b5e2086cda0a441fffb13acf9103721a0 diff --git a/src/wherecode.c b/src/wherecode.c index 49e5f90c56..f195074d6b 100644 --- a/src/wherecode.c +++ b/src/wherecode.c @@ -149,14 +149,7 @@ void sqlite3WhereAddExplainText( sqlite3StrAccumInit(&str, db, zBuf, sizeof(zBuf), SQLITE_MAX_LENGTH); str.printfFlags = SQLITE_PRINTF_INTERNAL; -#if 1 - if( (flags & WHERE_FLEX_SEARCH)!=0 && isSearch ){ - sqlite3_str_appendf(&str, "FLEX-SEARCH %S", pItem); - }else -#endif - { - sqlite3_str_appendf(&str, "%s %S", isSearch ? "SEARCH" : "SCAN", pItem); - } + sqlite3_str_appendf(&str, "%s %S", isSearch ? "SEARCH" : "SCAN", pItem); if( (flags & (WHERE_IPK|WHERE_VIRTUALTABLE))==0 ){ const char *zFmt = 0; Index *pIdx; @@ -182,6 +175,9 @@ void sqlite3WhereAddExplainText( sqlite3_str_appendf(&str, zFmt, pIdx->zName); explainIndexRange(&str, pLoop); } + if( (flags & WHERE_FLEX_SEARCH)!=0 && isSearch ){ + sqlite3_str_appendf(&str, " OR SCAN"); + } }else if( (flags & WHERE_IPK)!=0 && (flags & WHERE_CONSTRAINT)!=0 ){ char cRangeOp; #if 0 /* Better output, but breaks many tests */ diff --git a/test/autoindex3.test b/test/autoindex3.test index 26d97fd88d..7f53c76655 100644 --- a/test/autoindex3.test +++ b/test/autoindex3.test @@ -85,7 +85,7 @@ do_eqp_test 220 { select count(*) from u, v where u.b = v.b and v.e > 34; } { QUERY PLAN - |--FLEX-SEARCH v USING INDEX ve (e>?) + |--SEARCH v USING INDEX ve (e>?) OR SCAN |--BLOOM FILTER ON u (b=?) `--SEARCH u USING AUTOMATIC COVERING INDEX (b=?) } @@ -119,10 +119,10 @@ do_eqp_test 310 { QUERY PLAN |--CO-ROUTINE children | |--SETUP - | | `--FLEX-SEARCH t2 USING INDEX x1 (pid=? AND rx=?) + | | `--SEARCH t2 USING INDEX x1 (pid=? AND rx=?) OR SCAN | `--RECURSIVE STEP | |--SCAN children - | `--FLEX-SEARCH t2 USING INDEX x1 (pid=? AND rx=?) + | `--SEARCH t2 USING INDEX x1 (pid=? AND rx=?) OR SCAN `--SCAN children } diff --git a/test/cost.test b/test/cost.test index 29f3061459..070ae6fad5 100644 --- a/test/cost.test +++ b/test/cost.test @@ -110,7 +110,7 @@ do_eqp_test 5.3 { SELECT * FROM t2 WHERE x BETWEEN ? AND ? ORDER BY rowid; } { QUERY PLAN - |--FLEX-SEARCH t2 USING INDEX t2i1 (x>? AND x? AND x? AND path? AND path? AND path? AND path? AND path? AND path? AND path? AND path? AND O_ORDERDATE? AND O_ORDERDATE=100 AND a<300 ORDER BY b LIMIT 5; } { QUERY PLAN - |--FLEX-SEARCH t1 USING INDEX t1a (a>? AND a? AND a=100 AND a<300 ORDER BY b LIMIT $::N; } { QUERY PLAN - |--FLEX-SEARCH t1 USING INDEX t1a (a>? AND a? AND a