From: Sergey Bashirov <sergeybashirov@gmail.com>
Date: Tue, 15 Jul 2025 15:32:20 +0000 (+0300)
Subject: NFSD: Minor cleanup in layoutcommit decoding
X-Git-Tag: v6.18-rc1~54^2~33
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6bf1be3399e2635805074954011cb55745569788;p=thirdparty%2Fkernel%2Flinux.git

NFSD: Minor cleanup in layoutcommit decoding

Use the appropriate xdr function to decode the lc_newoffset field,
which is a boolean value. See RFC 8881, section 18.42.1.

Signed-off-by: Sergey Bashirov <sergeybashirov@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 2acc9abee668f..cbbb61fcdd499 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1802,7 +1802,7 @@ nfsd4_decode_layoutcommit(struct nfsd4_compoundargs *argp,
 	status = nfsd4_decode_stateid4(argp, &lcp->lc_sid);
 	if (status)
 		return status;
-	if (xdr_stream_decode_u32(argp->xdr, &lcp->lc_newoffset) < 0)
+	if (xdr_stream_decode_bool(argp->xdr, &lcp->lc_newoffset) < 0)
 		return nfserr_bad_xdr;
 	if (lcp->lc_newoffset) {
 		if (xdr_stream_decode_u64(argp->xdr, &lcp->lc_last_wr) < 0)