From: Anthony Iliopoulos <ailiop@suse.com>
Date: Sat, 22 Feb 2025 15:08:32 +0000 (+0100)
Subject: xfs_io: don't fail FS_IOC_FSGETXATTR on filesystems that lack support
X-Git-Tag: v6.14.0~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c01ed5d6d3a13af0068e8d05913126437c399e9;p=thirdparty%2Fxfsprogs-dev.git

xfs_io: don't fail FS_IOC_FSGETXATTR on filesystems that lack support

Not all filesystems implement the FS_IOC_FSGETXATTR ioctl, and in those
cases -ENOTTY will be returned. There is no need to return with an error
when this happens, so just silently return.

Without this fstest generic/169 fails on NFS that doesn't implement the
fileattr_get inode operation.

Fixes: e6b48f451a5d ("xfs_io: allow foreign FSes to show FS_IOC_FSGETXATTR details")
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---

diff --git a/io/stat.c b/io/stat.c
index 3ce3308d..d27f9168 100644
--- a/io/stat.c
+++ b/io/stat.c
@@ -104,8 +104,10 @@ print_extended_info(int verbose)
 	struct fsxattr fsx = {}, fsxa = {};
 
 	if ((ioctl(file->fd, FS_IOC_FSGETXATTR, &fsx)) < 0) {
-		perror("FS_IOC_GETXATTR");
-		exitcode = 1;
+		if (errno != ENOTTY) {
+			perror("FS_IOC_FSGETXATTR");
+			exitcode = 1;
+		}
 		return;
 	}