From: Pablo Neira Ayuso Date: Tue, 8 Jul 2025 22:14:44 +0000 (+0200) Subject: evaluate: mappings require set expression X-Git-Tag: v1.1.4~22 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c289f572e0ab4537d1a4d2d793d30d35c6f653b;p=thirdparty%2Fnftables.git evaluate: mappings require set expression While EXPR_CONCAT and EXPR_LIST share the same layout in struct expr, these expressions are not possible at this stage. Fall back to error out with "invalid mapping expression". Fixes: 02d44b4f9917 ("evaluate: fix expression data corruption") Signed-off-by: Pablo Neira Ayuso --- diff --git a/src/evaluate.c b/src/evaluate.c index a2d5d7c2..83381b4e 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -2211,8 +2211,6 @@ static int expr_evaluate_map(struct eval_ctx *ctx, struct expr **expr) mappings = map->mappings; switch (map->mappings->etype) { - case EXPR_CONCAT: - case EXPR_LIST: case EXPR_SET: set_flags |= mappings->set_flags; /* fallthrough */