From: Célestin Matte <celestin.matte@ensimag.fr>
Date: Fri, 14 Jun 2013 13:50:15 +0000 (+0200)
Subject: git-remote-mediawiki: rewrite unclear line of instructions
X-Git-Tag: v1.8.4-rc0~147^2~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c2fbe25fb8883da7925567a582dacda679e29dc;p=thirdparty%2Fgit.git

git-remote-mediawiki: rewrite unclear line of instructions

Subroutines' parameters should be assigned to variable before doing anything
else
Besides, existing instruction affected a variable inside a "if", which break
Git's coding style

Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index 3d1a324cf9..5e00833040 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -1333,7 +1333,8 @@ sub get_mw_namespace_id {
 }
 
 sub get_mw_namespace_id_for_page {
-	if (my ($namespace) = $_[0] =~ /^([^:]*):/) {
+	my $namespace = shift;
+	if ($namespace =~ /^([^:]*):/) {
 		return get_mw_namespace_id($namespace);
 	} else {
 		return;