From: Charles-François Natali <cf.natali@gmail.com>
Date: Sat, 7 Dec 2013 19:30:17 +0000 (+0100)
Subject: Issue #19857: Make sure that test_imaplib reaps server threads even in face of
X-Git-Tag: v3.4.0b2~307^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c527cf37f9ca6249f523ef3a59e27e64cc13e87;p=thirdparty%2FPython%2Fcpython.git

Issue #19857: Make sure that test_imaplib reaps server threads even in face of
error upon client disconnection.
---

diff --git a/Lib/test/test_imaplib.py b/Lib/test/test_imaplib.py
index daa8afeec55e..7c9afd9f39fb 100644
--- a/Lib/test/test_imaplib.py
+++ b/Lib/test/test_imaplib.py
@@ -210,13 +210,12 @@ class BaseThreadedNetworkedTests(unittest.TestCase):
 
     @contextmanager
     def reaped_pair(self, hdlr):
-        server, thread = self.make_server((support.HOST, 0), hdlr)
-        client = self.imap_class(*server.server_address)
-        try:
-            yield server, client
-        finally:
-            client.logout()
-            self.reap_server(server, thread)
+        with self.reaped_server(hdlr) as server:
+            client = self.imap_class(*server.server_address)
+            try:
+                yield server, client
+            finally:
+                client.logout()
 
     @reap_threads
     def test_connect(self):