From: Tom de Vries <tdevries@suse.de>
Date: Wed, 26 Feb 2025 06:46:40 +0000 (+0100)
Subject: [gdb/build] Fix unused var in dwarf2/read.c
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c6080171fc877e461da0f6df23a9c36a984ca55;p=thirdparty%2Fbinutils-gdb.git

[gdb/build] Fix unused var in dwarf2/read.c

On x86_64-linux, with gcc 7.5.0 I ran into a build breaker:
...
gdb/dwarf2/read.c: In function ‘void read_comp_units_from_section()’:
gdb/dwarf2/read.c:4297:31: error: unused variable ‘sig_type_it’ \
  [-Werror=unused-variable]
    auto [sig_type_it, inserted] = sig_types.emplace (sig_ptr);
                               ^
...

Fix this by dropping the unused variable.

Tested on x86_64-linux, by completing a build.
---

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index e044d1eb0e4..b4fd7e30cb7 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -4294,7 +4294,7 @@ read_comp_units_from_section (dwarf2_per_objfile *per_objfile,
 	  sig_type->type_offset_in_tu = cu_header.type_cu_offset_in_tu;
 	  this_cu.reset (sig_type.release ());
 
-	  auto [sig_type_it, inserted] = sig_types.emplace (sig_ptr);
+	  auto inserted = sig_types.emplace (sig_ptr).second;
 
 	  if (!inserted)
 	    complaint (_("debug type entry at offset %s is duplicate to"