From: Jeff Johnson Date: Tue, 11 Mar 2025 19:49:02 +0000 (-0700) Subject: modpost: require a MODULE_DESCRIPTION() X-Git-Tag: v6.15-rc1~11^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c6c1fc09de3;p=thirdparty%2Fkernel%2Flinux.git modpost: require a MODULE_DESCRIPTION() Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() has resulted in a warning with make W=1. Since that time, all known instances of this issue have been fixed. Therefore, now make it an error if a MODULE_DESCRIPTION() is not present. Signed-off-by: Jeff Johnson Signed-off-by: Masahiro Yamada --- diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 7f4c72eca72c1..92627e8d0e166 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1602,8 +1602,8 @@ static void read_symbols(const char *modname) namespace); } - if (extra_warn && !get_modinfo(&info, "description")) - warn("missing MODULE_DESCRIPTION() in %s\n", modname); + if (!get_modinfo(&info, "description")) + error("missing MODULE_DESCRIPTION() in %s\n", modname); } for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {