From: Tom de Vries <tdevries@suse.de>
Date: Sat, 19 Oct 2024 06:10:38 +0000 (+0200)
Subject: [gdbsupport] Use std::span-style iterators for gdb::array_view
X-Git-Tag: gdb-16-branchpoint~635
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6c8052f6b22fbb6ae1edc759454626d465ee317c;p=thirdparty%2Fbinutils-gdb.git

[gdbsupport] Use std::span-style iterators for gdb::array_view

There's a plan to replace gdb::array_view with std::span (PR31422), and making
gdb::array_view more like std::span helps with that.

One difference is that std::span has:
...
constexpr iterator begin() const noexcept;
constexpr const_iterator cbegin() const noexcept;
...
while gdb::array_view has:
...
constexpr T *begin () noexcept;
constexpr const T *begin () const noexcept;
...

Fix this by renaming the second variant to cbegin, and making the first
variant const.

Likewise for gdb::array_view::end.

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
---

diff --git a/gdbsupport/array-view.h b/gdbsupport/array-view.h
index 93842a40ec1..0dea26f67ac 100644
--- a/gdbsupport/array-view.h
+++ b/gdbsupport/array-view.h
@@ -157,11 +157,11 @@ public:
   constexpr T *data () noexcept { return m_array; }
   constexpr const T *data () const noexcept { return m_array; }
 
-  constexpr T *begin () noexcept { return m_array; }
-  constexpr const T *begin () const noexcept { return m_array; }
+  constexpr T *begin () const noexcept { return m_array; }
+  constexpr const T *cbegin () const noexcept { return m_array; }
 
-  constexpr T *end () noexcept { return m_array + m_size; }
-  constexpr const T *end () const noexcept { return m_array + m_size; }
+  constexpr T *end () const noexcept { return m_array + m_size; }
+  constexpr const T *cend () const noexcept { return m_array + m_size; }
 
   constexpr reference operator[] (size_t index) noexcept
   {