From: Xì Gà <vandug23@gmail.com>
Date: Fri, 16 Dec 2022 10:58:38 +0000 (+0700)
Subject: socks: fix username max size is 255 (0xFF)
X-Git-Tag: curl-7_87_0~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6cc18802f87fa8e86d27ebf9db32bf3a4ec184a5;p=thirdparty%2Fcurl.git

socks: fix username max size is 255 (0xFF)

Closes #10105

Reviewed-by: Daniel Gustafsson
---

diff --git a/lib/socks.c b/lib/socks.c
index 1b9f4fde7d..d491e089be 100644
--- a/lib/socks.c
+++ b/lib/socks.c
@@ -690,7 +690,7 @@ static CURLproxycode do_SOCKS5(struct Curl_cfilter *cf,
     socksreq[len++] = (unsigned char) proxy_user_len;
     if(sx->proxy_user && proxy_user_len) {
       /* the length must fit in a single byte */
-      if(proxy_user_len >= 255) {
+      if(proxy_user_len > 255) {
         failf(data, "Excessive user name length for proxy auth");
         return CURLPX_LONG_USER;
       }