From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 6 Jul 2023 22:37:57 +0000 (+1200)
Subject: ldb: Don’t pass NULL pointer into strcasecmp()
X-Git-Tag: tevent-0.16.0~1188
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6ce9c6a306d67c55e160e70ee50e5e732189c9d6;p=thirdparty%2Fsamba.git

ldb: Don’t pass NULL pointer into strcasecmp()

Doing so is undefined behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/common/ldb_msg.c b/lib/ldb/common/ldb_msg.c
index 3242447b544..dbc7e71b7b6 100644
--- a/lib/ldb/common/ldb_msg.c
+++ b/lib/ldb/common/ldb_msg.c
@@ -788,6 +788,18 @@ bool ldb_msg_element_equal_ordered(const struct ldb_message_element *el1,
 int ldb_msg_element_compare_name(struct ldb_message_element *el1,
 				 struct ldb_message_element *el2)
 {
+	if (el1->name == el2->name) {
+		return 0;
+	}
+
+	if (el1->name == NULL) {
+		return -1;
+	}
+
+	if (el2->name == NULL) {
+		return 1;
+	}
+
 	return ldb_attr_cmp(el1->name, el2->name);
 }