From: Julia Lawall Date: Thu, 10 Feb 2022 20:42:23 +0000 (+0100) Subject: mfd: sta2x11: Use GFP_KERNEL instead of GFP_ATOMIC X-Git-Tag: v5.18-rc1~111^2~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6ceb5f173ff15136f3d76e8d22aa8c6e784ea126;p=thirdparty%2Fkernel%2Flinux.git mfd: sta2x11: Use GFP_KERNEL instead of GFP_ATOMIC pci_driver probe functions aren't called with locks held and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead. Problem found with Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220210204223.104181-10-Julia.Lawall@inria.fr --- diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c index 1819c8fe4d8f6..02cc49daf2e3c 100644 --- a/drivers/mfd/sta2x11-mfd.c +++ b/drivers/mfd/sta2x11-mfd.c @@ -590,7 +590,7 @@ static int sta2x11_mfd_probe(struct pci_dev *pdev, /* Record this pdev before mfd_add_devices: their probe looks for it */ if (!sta2x11_mfd_find(pdev)) - sta2x11_mfd_add(pdev, GFP_ATOMIC); + sta2x11_mfd_add(pdev, GFP_KERNEL); /* Just 2 bars for all mfd's at present */ for (i = 0; i < 2; i++) {