From: Namjae Jeon <namjae.jeon@samsung.com>
Date: Wed, 7 Jul 2021 05:55:31 +0000 (+0900)
Subject: ksmbd: remove unneeded NULL check in for_each_netdev
X-Git-Tag: v5.15-rc1~183^2~9^2~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6cfbcf2f40e371ce36c030addc539597d058b3a9;p=thirdparty%2Fkernel%2Flinux.git

ksmbd: remove unneeded NULL check in for_each_netdev

netdev can never be NULL in for_each_netdev loop.
This patch remove unneeded NULL check.

Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index 994b95b6b3c2e..2811dfabfa75a 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -7004,11 +7004,6 @@ static int fsctl_query_iface_info_ioctl(struct ksmbd_conn *conn,
 
 	rtnl_lock();
 	for_each_netdev(&init_net, netdev) {
-		if (unlikely(!netdev)) {
-			rtnl_unlock();
-			return -EINVAL;
-		}
-
 		if (netdev->type == ARPHRD_LOOPBACK)
 			continue;