From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 26 Aug 2024 08:47:10 +0000 (+0200)
Subject: YaHTTP: Fix a non-virtual destructor warning in the `HTTPBase` class
X-Git-Tag: rec-5.2.0-alpha1~129^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6d1b9a3b179126ca50e62f4afff5448e2b51ea2e;p=thirdparty%2Fpdns.git

YaHTTP: Fix a non-virtual destructor warning in the `HTTPBase` class

`g++` 14.2.1's `-Wnon-virtual-dtor` complains:
```
‘class YaHTTP::HTTPBase’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
```
---

diff --git a/ext/yahttp/yahttp/reqresp.hpp b/ext/yahttp/yahttp/reqresp.hpp
index 4db53bec85..e420c24a15 100644
--- a/ext/yahttp/yahttp/reqresp.hpp
+++ b/ext/yahttp/yahttp/reqresp.hpp
@@ -98,6 +98,7 @@ namespace YaHTTP {
     HTTPBase() {
       HTTPBase::initialize();
     };
+    virtual ~HTTPBase() = default;
 
     virtual void initialize() {
       kind = 0;