From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 23 Jun 2021 14:02:39 +0000 (+0200)
Subject: pwm: ep93xx: Implement .apply callback
X-Git-Tag: v5.14-rc1~42^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6d45374af539c84d17cfcf5a4e96bc4b2ca421e6;p=thirdparty%2Fkernel%2Flinux.git

pwm: ep93xx: Implement .apply callback

To ease review this reuses the formerly implemented callbacks.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---

diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
index 4ca70794ad966..3ef4b41bfd667 100644
--- a/drivers/pwm/pwm-ep93xx.c
+++ b/drivers/pwm/pwm-ep93xx.c
@@ -156,13 +156,48 @@ static void ep93xx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 	clk_disable(ep93xx_pwm->clk);
 }
 
+static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
+			    const struct pwm_state *state)
+{
+	int ret;
+	bool enabled = state->enabled;
+
+	if (state->polarity != pwm->state.polarity) {
+		if (enabled) {
+			ep93xx_pwm_disable(chip, pwm);
+			enabled = false;
+		}
+
+		ret = ep93xx_pwm_polarity(chip, pwm, state->polarity);
+		if (ret)
+			return ret;
+	}
+
+	if (!state->enabled) {
+		if (enabled)
+			ep93xx_pwm_disable(chip, pwm);
+
+		return 0;
+	}
+
+	if (state->period != pwm->state.period ||
+	    state->duty_cycle != pwm->state.duty_cycle) {
+		ret = ep93xx_pwm_config(chip, pwm, (int)state->duty_cycle,
+					(int)state->period);
+		if (ret)
+			return ret;
+	}
+
+	if (!enabled)
+		return ep93xx_pwm_enable(chip, pwm);
+
+	return 0;
+}
+
 static const struct pwm_ops ep93xx_pwm_ops = {
 	.request = ep93xx_pwm_request,
 	.free = ep93xx_pwm_free,
-	.config = ep93xx_pwm_config,
-	.set_polarity = ep93xx_pwm_polarity,
-	.enable = ep93xx_pwm_enable,
-	.disable = ep93xx_pwm_disable,
+	.apply = ep93xx_pwm_apply,
 	.owner = THIS_MODULE,
 };