From: drh <drh@noemail.net>
Date: Wed, 1 Jan 2020 01:26:05 +0000 (+0000)
Subject: Issue OP_ReleaseReg opcodes against the array of registers used to compute
X-Git-Tag: version-3.31.0~104
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6d67aff0e3d613b2decc7d9a9e93d5d6be633edc;p=thirdparty%2Fsqlite.git

Issue OP_ReleaseReg opcodes against the array of registers used to compute
index records after the index record has been computed.

FossilOrigin-Name: e3330861b4deab7c7cc09ad8b936d633c600b9fb4e274801efeaaf94e5c860b4
---

diff --git a/manifest b/manifest
index 7bf247d565..f74d206ba8 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Remove\san\sincorrect\sassert()\sstatement.\s\sTicket\s[46fcd700b855e6d1]
-D 2019-12-31T23:17:35.723
+C Issue\sOP_ReleaseReg\sopcodes\sagainst\sthe\sarray\sof\sregisters\sused\sto\scompute\nindex\srecords\safter\sthe\sindex\srecord\shas\sbeen\scomputed.
+D 2020-01-01T01:26:05.547
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -489,7 +489,7 @@ F src/hash.c 8d7dda241d0ebdafb6ffdeda3149a412d7df75102cecfc1021c98d6219823b19
 F src/hash.h 9d56a9079d523b648774c1784b74b89bd93fac7b365210157482e4319a468f38
 F src/hwtime.h cb1d7e3e1ed94b7aa6fde95ae2c2daccc3df826be26fc9ed7fd90d1750ae6144
 F src/in-operator.md 10cd8f4bcd225a32518407c2fb2484089112fd71
-F src/insert.c 97afb0bf06d7fd7b820f6de3e42cf60beb5cd10131828c29b131b2614bbb1f39
+F src/insert.c 2cadbc8a81ea03f6cc1b629f6019192c9c5e6bcfaa8356e53511047f290cdd76
 F src/legacy.c d7874bc885906868cd51e6c2156698f2754f02d9eee1bae2d687323c3ca8e5aa
 F src/loadext.c d74f5e7bd51f3c9d283442473eb65aef359664efd6513591c03f01881c4ae2da
 F src/main.c 868ae7db7a54fe859bf2ca8b7a4f24e9fa03a6134abfb7c9801d08411ef5dacb
@@ -1853,7 +1853,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 3bd095a53119c368fe30e539983588b27957203344cf427405b9a64784b8eba7
-R 9a290668b8247b93cd51ae150764a4e7
+P eca7ec9cda4606c4104bcb8da315070b615713db9f3444579c6a3e96b0aad02f
+R 831eba5ca2213a1142c1d3fcf8abb412
 U drh
-Z 3a723a31e4b46687e83c27b7c95d8d29
+Z d9905a9f70d8f738c4685ad63b39c0a5
diff --git a/manifest.uuid b/manifest.uuid
index fe05dead13..6ac57e8761 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-eca7ec9cda4606c4104bcb8da315070b615713db9f3444579c6a3e96b0aad02f
\ No newline at end of file
+e3330861b4deab7c7cc09ad8b936d633c600b9fb4e274801efeaaf94e5c860b4
\ No newline at end of file
diff --git a/src/insert.c b/src/insert.c
index d778e4b457..3b4ad56403 100644
--- a/src/insert.c
+++ b/src/insert.c
@@ -1976,6 +1976,7 @@ void sqlite3GenerateConstraintChecks(
       sqlite3SetMakeRecordP5(v, pIdx->pTable);
     }
 #endif
+    sqlite3VdbeReleaseRegisters(pParse, regIdx, pIdx->nColumn, 0);
 
     /* In an UPDATE operation, if this index is the PRIMARY KEY index 
     ** of a WITHOUT ROWID table and there has been no change the