From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Mon, 10 Mar 2025 15:54:13 +0000 (-0400)
Subject: bcachefs: Don't create bch_io_failures unless it's needed
X-Git-Tag: v6.15-rc1~146^2~52
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6d80fca9efe9255369aa91e85e8f3367c42acdde;p=thirdparty%2Flinux.git

bcachefs: Don't create bch_io_failures unless it's needed

Only needed in retry path, no point in wasting stack space.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/io_read.h b/fs/bcachefs/io_read.h
index 73275da5d2c4b..6bdb8efb4cd14 100644
--- a/fs/bcachefs/io_read.h
+++ b/fs/bcachefs/io_read.h
@@ -147,13 +147,11 @@ void __bch2_read(struct bch_fs *, struct bch_read_bio *, struct bvec_iter,
 static inline void bch2_read(struct bch_fs *c, struct bch_read_bio *rbio,
 			     subvol_inum inum)
 {
-	struct bch_io_failures failed = { .nr = 0 };
-
 	BUG_ON(rbio->_state);
 
 	rbio->subvol = inum.subvol;
 
-	__bch2_read(c, rbio, rbio->bio.bi_iter, inum, &failed,
+	__bch2_read(c, rbio, rbio->bio.bi_iter, inum, NULL,
 		    BCH_READ_retry_if_stale|
 		    BCH_READ_may_promote|
 		    BCH_READ_user_mapped);