From: ZheNing Hu <adlternative@gmail.com>
Date: Sun, 5 Jun 2022 13:37:28 +0000 (+0000)
Subject: read-cache.c: reduce unnecessary cache entry name copying
X-Git-Tag: v2.37.0-rc0~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6d858341d284e08320dc2dbf1952d7a37884e5f3;p=thirdparty%2Fgit.git

read-cache.c: reduce unnecessary cache entry name copying

575fa8a3 (read-cache: read data in a hash-independent way,
2019-02-19) added a new code to copy from the on-disk data into the
name member of the in-core cache entry, which is already done
immediately after that in a way that takes prefix-compression into
account.

Remove this code, as it is not just unnecessary, but also can be
reading beyond the on-disk data, when we are copying very long
prefix string from the previous entry.

Signed-off-by: ZheNing Hu <adlternative@gmail.com>
[jc: rewrote the log message with Réne's findings]
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/read-cache.c b/read-cache.c
index 4df97e185e..02789a63ad 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1944,8 +1944,6 @@ static struct cache_entry *create_from_disk(struct mem_pool *ce_mem_pool,
 	ce->ce_namelen = len;
 	ce->index = 0;
 	oidread(&ce->oid, ondisk->data);
-	memcpy(ce->name, name, len);
-	ce->name[len] = '\0';
 
 	if (expand_name_field) {
 		if (copy_len)