From: Qais Yousef <qais.yousef@arm.com>
Date: Mon, 7 Jun 2021 16:11:11 +0000 (+0100)
Subject: uclampset: Fix left over optind++
X-Git-Tag: v2.38-rc1~476
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6da826a521e2bfec5f239ea9229a0e707583271c;p=thirdparty%2Futil-linux.git

uclampset: Fix left over optind++

The code was changed to use ':' in getopt_long() but these were left
over by mistake causing weird random errors when using these options
depending on the order they were fed.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
---

diff --git a/schedutils/uclampset.c b/schedutils/uclampset.c
index 444e350f41..e09d6a7f9f 100644
--- a/schedutils/uclampset.c
+++ b/schedutils/uclampset.c
@@ -253,7 +253,6 @@ int main(int argc, char **argv)
 		case 'p':
 			errno = 0;
 			ctl->pid = strtos32_or_err(optarg, _("invalid PID argument"));
-			optind++;
 			break;
 		case 's':
 			ctl->system = 1;
@@ -268,13 +267,11 @@ int main(int argc, char **argv)
 			ctl->util_min = strtos32_or_err(optarg, _("invalid util_min argument"));
 			ctl->util_min_set = 1;
 			validate_util(ctl->util_min);
-			optind++;
 			break;
 		case 'M':
 			ctl->util_max = strtos32_or_err(optarg, _("invalid util_max argument"));
 			ctl->util_max_set = 1;
 			validate_util(ctl->util_max);
-			optind++;
 			break;
 		case 'V':
 			print_version(EXIT_SUCCESS);