From: Christoph Hellwig Date: Mon, 13 Jan 2025 14:12:15 +0000 (+0100) Subject: xfs: remove the extra buffer reference in xfs_buf_submit X-Git-Tag: v6.14-rc1~132^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6dca5abb3d10e27e919e5344ac07e057f443c318;p=thirdparty%2Flinux.git xfs: remove the extra buffer reference in xfs_buf_submit Nothing touches the buffer after it has been submitted now, so the need for the extra transient reference went away as well. Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Acked-by: Dave Chinner Signed-off-by: Carlos Maiolino --- diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index e0a34c2aaaaf1..49d087d9ba485 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1643,13 +1643,6 @@ xfs_buf_submit( return; } - /* - * Grab a reference so the buffer does not go away underneath us. For - * async buffers, I/O completion drops the callers reference, which - * could occur before submission returns. - */ - xfs_buf_hold(bp); - if (bp->b_flags & XBF_WRITE) xfs_buf_wait_unpin(bp); @@ -1672,20 +1665,13 @@ xfs_buf_submit( goto done; xfs_buf_submit_bio(bp); - goto rele; + return; done: if (bp->b_error || !(bp->b_flags & XBF_ASYNC)) xfs_buf_ioend(bp); else xfs_buf_ioend_async(bp); -rele: - /* - * Release the hold that keeps the buffer referenced for the entire - * I/O. Note that if the buffer is async, it is not safe to reference - * after this release. - */ - xfs_buf_rele(bp); } void *