From: Dmitry Osipenko Date: Thu, 19 Mar 2020 21:23:20 +0000 (+0300) Subject: dmaengine: tegra-apb: Don't save/restore IRQ flags in interrupt handler X-Git-Tag: v5.7-rc1~114^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6de88ea4ff665040e62e3b3ffea01e388ae09ac0;p=thirdparty%2Fkernel%2Flinux.git dmaengine: tegra-apb: Don't save/restore IRQ flags in interrupt handler The interrupt is already disabled while interrupt handler is running, and thus, there is no need to save/restore the IRQ flags within the spinlock. Signed-off-by: Dmitry Osipenko Link: https://lore.kernel.org/r/20200319212321.3297-1-digetx@gmail.com Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index c5da4444a6aeb..e973cfa69e622 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -670,10 +670,9 @@ static void tegra_dma_tasklet(unsigned long data) static irqreturn_t tegra_dma_isr(int irq, void *dev_id) { struct tegra_dma_channel *tdc = dev_id; - unsigned long flags; u32 status; - spin_lock_irqsave(&tdc->lock, flags); + spin_lock(&tdc->lock); trace_tegra_dma_isr(&tdc->dma_chan, irq); status = tdc_read(tdc, TEGRA_APBDMA_CHAN_STATUS); @@ -681,11 +680,11 @@ static irqreturn_t tegra_dma_isr(int irq, void *dev_id) tdc_write(tdc, TEGRA_APBDMA_CHAN_STATUS, status); tdc->isr_handler(tdc, false); tasklet_schedule(&tdc->tasklet); - spin_unlock_irqrestore(&tdc->lock, flags); + spin_unlock(&tdc->lock); return IRQ_HANDLED; } - spin_unlock_irqrestore(&tdc->lock, flags); + spin_unlock(&tdc->lock); dev_info(tdc2dev(tdc), "Interrupt already served status 0x%08x\n", status);