From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 8 Apr 2025 18:43:14 +0000 (-0700)
Subject: Merge branch 'ps/reftable-sans-compat-util'
X-Git-Tag: v2.50.0-rc0~136
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6e2a3b8ae0e07c0c31f2247fec49b77b5d903a83;p=thirdparty%2Fgit.git

Merge branch 'ps/reftable-sans-compat-util'

Make the code in reftable library less reliant on the service
routines it used to borrow from Git proper, to make it easier to
use by external users of the library.

* ps/reftable-sans-compat-util:
  Makefile: skip reftable library for Coccinelle
  reftable: decouple from Git codebase by pulling in "compat/posix.h"
  git-compat-util.h: split out POSIX-emulating bits
  compat/mingw: split out POSIX-related bits
  reftable/basics: introduce `REFTABLE_UNUSED` annotation
  reftable/basics: stop using `SWAP()` macro
  reftable/stack: stop using `sleep_millisec()`
  reftable/system: introduce `reftable_rand()`
  reftable/reader: stop using `ARRAY_SIZE()` macro
  reftable/basics: provide wrappers for big endian conversion
  reftable/basics: stop using `st_mult()` in array allocators
  reftable: stop using `BUG()` in trivial cases
  reftable/record: don't `BUG()` in `reftable_record_cmp()`
  reftable/record: stop using `BUG()` in `reftable_record_init()`
  reftable/record: stop using `COPY_ARRAY()`
  reftable/blocksource: stop using `xmmap()`
  reftable/stack: stop using `write_in_full()`
  reftable/stack: stop using `read_in_full()`
---

6e2a3b8ae0e07c0c31f2247fec49b77b5d903a83
diff --cc reftable/record.c
index d9fba8ff38,142853d507..c0080024ed
--- a/reftable/record.c
+++ b/reftable/record.c
@@@ -801,9 -812,9 +807,9 @@@ static int reftable_log_record_encode(c
  	string_view_consume(&s, n);
  
  	if (s.len < 2)
 -		return -1;
 +		return REFTABLE_ENTRY_TOO_BIG_ERROR;
  
- 	put_be16(s.buf, r->value.update.tz_offset);
+ 	reftable_put_be16(s.buf, r->value.update.tz_offset);
  	string_view_consume(&s, 2);
  
  	n = encode_string(