From: Colin Ian King Date: Thu, 16 Mar 2017 23:21:45 +0000 (+0000) Subject: staging: wilc1000: fix incorrect copy of pmkid data X-Git-Tag: v4.12-rc1~84^2~469 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6e9f6b54c51f23fd663912d720c3420c057e5bfc;p=thirdparty%2Fkernel%2Flinux.git staging: wilc1000: fix incorrect copy of pmkid data The pmkid data is meant be be copied to the previous item in the pmkidlist, however the code is just copying the data to itself because the src index into pmkidlist is the same as the dst index into pmkidlist. Fix this with i + 1 instead of i. Detected by CoverityScan,CID#13339465 ("Overlapping buffer in memory copy") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index a37896fcd6830..4034f400fff99 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1346,7 +1346,7 @@ static int del_pmksa(struct wiphy *wiphy, struct net_device *netdev, priv->pmkid_list.pmkidlist[i + 1].bssid, ETH_ALEN); memcpy(priv->pmkid_list.pmkidlist[i].pmkid, - priv->pmkid_list.pmkidlist[i].pmkid, + priv->pmkid_list.pmkidlist[i + 1].pmkid, PMKID_LEN); } priv->pmkid_list.numpmkid--;