From: Johannes Sixt Date: Sat, 30 Jan 2021 16:22:25 +0000 (+0100) Subject: annotate-tests: quote variable expansions containing path names X-Git-Tag: v2.30.1~2^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6eaf624dea685f3d61815efeb31d7ff06197330c;p=thirdparty%2Fgit.git annotate-tests: quote variable expansions containing path names The test case added by 9466e3809d ("blame: enable funcname blaming with userdiff driver", 2020-11-01) forgot to quote variable expansions. This causes failures when the current directory contains blanks. One variable that the test case introduces will not have IFS characters and could remain without quotes, but let's quote all expansions for consistency, not just the one that has the path name. Signed-off-by: Johannes Sixt Acked-by: Philippe Blain Signed-off-by: Junio C Hamano --- diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh index 3aee61d2cc..a2e46572d5 100644 --- a/t/annotate-tests.sh +++ b/t/annotate-tests.sh @@ -483,12 +483,12 @@ test_expect_success 'setup -L :funcname with userdiff driver' ' echo "fortran-* diff=fortran" >.gitattributes && fortran_file=fortran-external-function && orig_file="$TEST_DIRECTORY/t4018/$fortran_file" && - cp $orig_file . && - git add $fortran_file && + cp "$orig_file" . && + git add "$fortran_file" && GIT_AUTHOR_NAME="A" GIT_AUTHOR_EMAIL="A@test.git" \ git commit -m "add fortran file" && - sed -e "s/ChangeMe/IWasChanged/" <"$orig_file" >$fortran_file && - git add $fortran_file && + sed -e "s/ChangeMe/IWasChanged/" <"$orig_file" >"$fortran_file" && + git add "$fortran_file" && GIT_AUTHOR_NAME="B" GIT_AUTHOR_EMAIL="B@test.git" \ git commit -m "change fortran file" '