From: Maxime Ripard Date: Fri, 21 Jun 2024 15:20:32 +0000 (+0100) Subject: drm/vc4: hdmi: Warn if writing to an unknown HDMI register X-Git-Tag: v6.13-rc1~122^2~23^2~83 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6ecfe7c2f925b805efbd1c1e2a93890ea7ec37fd;p=thirdparty%2Fkernel%2Flinux.git drm/vc4: hdmi: Warn if writing to an unknown HDMI register The VC4 HDMI driver has a bunch of accessors to read from a register. The read accessor was warning when accessing an unknown register, but the write one was just returning silently. Let's make sure we warn also when writing to an unknown register. Signed-off-by: Maxime Ripard Reviewed-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-9-dave.stevenson@raspberrypi.com Signed-off-by: Dave Stevenson --- diff --git a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h index b04b2fc8d8317..68455ce513e77 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h +++ b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h @@ -498,8 +498,11 @@ static inline void vc4_hdmi_write(struct vc4_hdmi *hdmi, field = &variant->registers[reg]; base = __vc4_hdmi_get_field_base(hdmi, field->reg); - if (!base) + if (!base) { + dev_warn(&hdmi->pdev->dev, + "Unknown register ID %u\n", reg); return; + } writel(value, base + field->offset); }