From: Uwe Kleine-König Date: Tue, 30 May 2023 08:16:48 +0000 (+0200) Subject: spi: mt65xx: Don't disguise a "return 0" as "return ret" X-Git-Tag: v6.5-rc1~170^2~27^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6f089e986778d3657247fdc2b38bd38de796732b;p=thirdparty%2Fkernel%2Flinux.git spi: mt65xx: Don't disguise a "return 0" as "return ret" Because of the earlier if (ret) return ret; ret is always zero at the end of mtk_spi_suspend(). Write it as explicit return 0 for slightly improved clearness. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230530081648.2199419-4-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c index f532cee3461e8..5a0b04c1c7556 100644 --- a/drivers/spi/spi-mt65xx.c +++ b/drivers/spi/spi-mt65xx.c @@ -1312,7 +1312,7 @@ static int mtk_spi_suspend(struct device *dev) clk_disable_unprepare(mdata->spi_hclk); } - return ret; + return 0; } static int mtk_spi_resume(struct device *dev)