From: Philippe Mathieu-Daudé Date: Fri, 19 Jul 2019 13:14:19 +0000 (+0200) Subject: json: Move switch 'fall through' comment to correct place X-Git-Tag: v4.2.0-rc0~221^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6f0dd6c5d25a0355b1dfc36dd8ed40dc053b3d54;p=thirdparty%2Fqemu.git json: Move switch 'fall through' comment to correct place Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: qobject/json-parser.c: In function ‘parse_literal’: qobject/json-parser.c:492:24: error: this statement may fall through [-Werror=implicit-fallthrough=] 492 | case JSON_INTEGER: { | ^ qobject/json-parser.c:524:5: note: here 524 | case JSON_FLOAT: | ^~~~ Correctly place the 'fall through' comment. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Message-Id: <20190719131425.10835-2-philmd@redhat.com> Signed-off-by: Laurent Vivier --- diff --git a/qobject/json-parser.c b/qobject/json-parser.c index 7d23e12e337..d083810d378 100644 --- a/qobject/json-parser.c +++ b/qobject/json-parser.c @@ -519,8 +519,8 @@ static QObject *parse_literal(JSONParserContext *ctxt) } assert(ret == -ERANGE); } - /* fall through to JSON_FLOAT */ } + /* fall through to JSON_FLOAT */ case JSON_FLOAT: /* FIXME dependent on locale; a pervasive issue in QEMU */ /* FIXME our lexer matches RFC 8259 in forbidding Inf or NaN,