From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 17 Nov 2023 08:33:54 +0000 (+0100)
Subject: dnsdist: More delinting
X-Git-Tag: dnsdist-1.9.0-alpha4~10^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6f36fb8ff9d2be8e50701ea70050329b13681a16;p=thirdparty%2Fpdns.git

dnsdist: More delinting
---

diff --git a/pdns/dnsdistdist/dnsdist-dynblocks.cc b/pdns/dnsdistdist/dnsdist-dynblocks.cc
index e09130a530..f0bb97f69c 100644
--- a/pdns/dnsdistdist/dnsdist-dynblocks.cc
+++ b/pdns/dnsdistdist/dnsdist-dynblocks.cc
@@ -855,7 +855,7 @@ bool DynBlockRulesGroup::DynBlockRule::matches(const struct timespec& when)
     return false;
   }
 
-  if (d_seconds && when < d_cutOff) {
+  if (d_seconds > 0 && when < d_cutOff) {
     return false;
   }
 
@@ -872,7 +872,7 @@ bool DynBlockRulesGroup::DynBlockRule::rateExceeded(unsigned int count, const st
     return false;
   }
 
-  double delta = d_seconds ? d_seconds : DiffTime(now, d_minTime);
+  double delta = d_seconds > 0 ? d_seconds : DiffTime(now, d_minTime);
   double limit = delta * d_rate;
   return (count > limit);
 }
@@ -887,7 +887,7 @@ bool DynBlockRulesGroup::DynBlockRule::warningRateExceeded(unsigned int count, c
     return false;
   }
 
-  double delta = d_seconds ? d_seconds : DiffTime(now, d_minTime);
+  double delta = d_seconds > 0 ? d_seconds : DiffTime(now, d_minTime);
   double limit = delta * d_warningRate;
   return (count > limit);
 }
@@ -949,7 +949,7 @@ bool DynBlockRulesGroup::DynBlockCacheMissRatioRule::checkGlobalCacheHitRatio()
   if (globalMisses == 0 || globalHits == 0) {
     return false;
   }
-  double globalCacheHitRatio = static_cast<double>(globalHits) / (globalHits + globalMisses);
+  double globalCacheHitRatio = (globalHits * static_cast<double>(1.0)) / (globalHits + globalMisses);
   return globalCacheHitRatio >= d_minimumGlobalCacheHitRatio;
 }
 
diff --git a/pdns/dnsdistdist/test-dnsdistdynblocks_hh.cc b/pdns/dnsdistdist/test-dnsdistdynblocks_hh.cc
index df481eb09a..fbd24dd973 100644
--- a/pdns/dnsdistdist/test-dnsdistdynblocks_hh.cc
+++ b/pdns/dnsdistdist/test-dnsdistdynblocks_hh.cc
@@ -846,7 +846,9 @@ BOOST_FIXTURE_TEST_CASE(test_DynBlockRulesGroup_CacheMissRatio, TestFixture) {
   uint16_t size = 42;
   dnsdist::Protocol outgoingProtocol = dnsdist::Protocol::DoUDP;
   unsigned int responseTime = 100 * 1000; /* 100ms */
-  struct timespec now;
+  struct timespec now
+  {
+  };
   gettime(&now);
   NetmaskTree<DynBlock, AddressAndPortRange> emptyNMG;