From: Tom Tromey <tom@tromey.com>
Date: Wed, 6 Dec 2023 15:32:52 +0000 (-0700)
Subject: Refactor 'maint set dwarf synchronous' handling
X-Git-Tag: gdb-15-branchpoint~1232
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6f49611564662fe56255359cd7d227b5b5fc64dc;p=thirdparty%2Fbinutils-gdb.git

Refactor 'maint set dwarf synchronous' handling

The new .debug_names reader will reuse the background reading
infrastructure of the cooked index code.  In order to share the
handling of 'maint set dwarf synchronous' -- and to avoid having to
export this global -- this patch refactors this to be handled directly
in dwarf2_initialize_objfile.
---

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 8f2b7a35f27..e0eb1f9ce3c 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -3267,6 +3267,10 @@ dwarf2_initialize_objfile (struct objfile *objfile,
       global_index_cache.miss ();
       objfile->qf.push_front (make_cooked_index_funcs (per_objfile));
     }
+
+  if (dwarf_synchronous && per_bfd->index_table != nullptr)
+    per_bfd->index_table->wait_completely ();
+
   return true;
 }
 
@@ -16920,9 +16924,6 @@ make_cooked_index_funcs (dwarf2_per_objfile *per_objfile)
      avoids races.  */
   idx->start_reading ();
 
-  if (dwarf_synchronous)
-    idx->wait_completely ();
-
   return quick_symbol_functions_up (new cooked_index_functions);
 }