From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 7 Apr 2023 17:01:33 +0000 (+0200)
Subject: MINOR: quic: Add a trace for packet with an ACK frame
X-Git-Tag: v2.8-dev8~184
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6fd2576d5ebbe90039cc918d01d0f62970f7cd67;p=thirdparty%2Fhaproxy.git

MINOR: quic: Add a trace for packet with an ACK frame

As the ACK frames are not added to the packet list of ack-eliciting frames,
it could not be traced. But there is a flag to identify such packet.
Let's use it to add this information to the traces of TX packets.

Must be backported to 2.6 and 2.7.
---

diff --git a/src/quic_conn.c b/src/quic_conn.c
index 0cce20b2c0..2d90ab3ef4 100644
--- a/src/quic_conn.c
+++ b/src/quic_conn.c
@@ -658,6 +658,8 @@ static void quic_trace(enum trace_level level, uint64_t mask, const struct trace
 			             (unsigned long long)qc->path->in_flight);
 			if (pkt) {
 				const struct quic_frame *frm;
+				if (pkt->flags & QUIC_FL_TX_PACKET_ACK)
+				    chunk_appendf(&trace_buf, " ack");
 				chunk_appendf(&trace_buf, " pn=%lu(%s) iflen=%llu",
 				              (unsigned long)pkt->pn_node.key,
 				              pkt->pktns == &qc->pktns[QUIC_TLS_PKTNS_INITIAL] ? "I" :