From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 4 Jun 2021 08:23:11 +0000 (+0200)
Subject: BUG/MINOR: quic: Wrong RX packet reference counter usage
X-Git-Tag: v2.5-dev8~125
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6fe21b0dec1c59ff0926bf49393cc3a1712bea28;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Wrong RX packet reference counter usage

No need to call free_quic_rx_packet() after calling quic_rx_packet_eb64_delete()
as this latter already calls quic_rx_packet_refdec() also called by
free_quic_rx_packet().
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index cb00c02fdc..074cc601c4 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2492,7 +2492,6 @@ int qc_treat_rx_pkts(struct quic_enc_level *el, struct quic_conn_ctx *ctx)
 					            QUIC_EV_CONN_ELRXPKTS, ctx->conn);
 					node = eb64_next(node);
 					quic_rx_packet_eb64_delete(&pkt->pn_node);
-					free_quic_rx_packet(pkt);
 					goto err;
 				}
 
@@ -2500,7 +2499,6 @@ int qc_treat_rx_pkts(struct quic_enc_level *el, struct quic_conn_ctx *ctx)
 		}
 		node = eb64_next(node);
 		quic_rx_packet_eb64_delete(&pkt->pn_node);
-		free_quic_rx_packet(pkt);
 	}
 
 	if (!qc_treat_rx_crypto_frms(el, ctx))