From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Fri, 17 Aug 2018 11:29:04 +0000 (+0200)
Subject: make edit-zone catch zoneparser exceptions as well
X-Git-Tag: dnsdist-1.3.3~157^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7002805fcf66802b52dbf14028ff15dd47ecee8f;p=thirdparty%2Fpdns.git

make edit-zone catch zoneparser exceptions as well
---

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 2df72901ff..c275f71b90 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -920,19 +920,20 @@ int editZone(DNSSECKeeper& dk, const DNSName &zone) {
   ZoneParserTNG zpt(tmpnam, g_rootdnsname);
   DNSResourceRecord zrr;
   map<pair<DNSName,uint16_t>, vector<DNSRecord> > grouped;
-  while(zpt.get(zrr)) {
-    try {
-      DNSRecord dr(zrr);
-      post.push_back(dr);
-      grouped[{dr.d_name,dr.d_type}].push_back(dr);
-    }
-    catch(std::exception& e) {
-      cerr<<"Problem "<<e.what()<<" "<<zpt.getLineOfFile()<<endl;
-      auto fnum = zpt.getLineNumAndFile();
-      gotoline = fnum.second;
-      goto reAsk;
+  try {
+    while(zpt.get(zrr)) {
+        DNSRecord dr(zrr);
+        post.push_back(dr);
+        grouped[{dr.d_name,dr.d_type}].push_back(dr);
     }
   }
+  catch(std::exception& e) {
+    cerr<<"Problem: "<<e.what()<<" "<<zpt.getLineOfFile()<<endl;
+    auto fnum = zpt.getLineNumAndFile();
+    gotoline = fnum.second;
+    goto reAsk;
+  }
+
   sort(post.begin(), post.end(), DNSRecord::prettyCompare);
   checkrr.clear();