From: Stefan Metzmacher <metze@samba.org>
Date: Wed, 29 Jan 2025 10:36:52 +0000 (+0100)
Subject: s4:auth: let auth_domain_admin_user_info_dc() use talloc_zero_array(struct auth_SidAttr)
X-Git-Tag: tevent-0.17.0~774
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=700d5111bd2c429ceee51126dc428cb3ce671810;p=thirdparty%2Fsamba.git

s4:auth: let auth_domain_admin_user_info_dc() use talloc_zero_array(struct auth_SidAttr)

This means we won't leave uninitialized memory if
struct auth_SidAttr changes.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/source4/auth/system_session.c b/source4/auth/system_session.c
index 8b4b65f3cd4..3a58f130462 100644
--- a/source4/auth/system_session.c
+++ b/source4/auth/system_session.c
@@ -247,7 +247,13 @@ static NTSTATUS auth_domain_admin_user_info_dc(TALLOC_CTX *mem_ctx,
 	NT_STATUS_HAVE_NO_MEMORY(user_info_dc);
 
 	user_info_dc->num_sids = 8;
-	user_info_dc->sids = talloc_array(user_info_dc, struct auth_SidAttr, user_info_dc->num_sids);
+	user_info_dc->sids = talloc_zero_array(user_info_dc,
+					       struct auth_SidAttr,
+					       user_info_dc->num_sids);
+	if (user_info_dc->sids == NULL) {
+		TALLOC_FREE(user_info_dc);
+		return NT_STATUS_NO_MEMORY;
+	}
 
 	user_info_dc->sids[PRIMARY_USER_SID_INDEX].sid = *domain_sid;
 	sid_append_rid(&user_info_dc->sids[PRIMARY_USER_SID_INDEX].sid, DOMAIN_RID_ADMINISTRATOR);