From: Colin Ian King Date: Tue, 23 Mar 2021 14:00:47 +0000 (+0100) Subject: media: dvb-frontends: Remove redundant error check on variable ret X-Git-Tag: v5.13-rc1~124^2~40 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7030a96bd99032c4565889082a8ab67db3b62180;p=thirdparty%2Fkernel%2Flinux.git media: dvb-frontends: Remove redundant error check on variable ret An earlier commit removed a call to lgdt3306a_spectral_inversion and omitted to remove the error return check. The check on ret is now redundant and can be removed. Addresses-Coverity: ("Logically dead code") Fixes: d4a3fa6652e3 ("media: dvb-frontends: lgdt3306a.c: remove dead code") Signed-off-by: Colin Ian King Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index 22d4844876950..136b76cb48077 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -1017,9 +1017,6 @@ static int lgdt3306a_set_parameters(struct dvb_frontend *fe) /* spectral_inversion defaults already set for VSB and QAM */ - if (lg_chkerr(ret)) - goto fail; - ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode); if (lg_chkerr(ret)) goto fail;