From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 4 May 2020 07:01:45 +0000 (+0200)
Subject: BUG/MEDIUM: h1: Don't compare host and authority if only h1 headers are parsed
X-Git-Tag: v2.2-dev7~26
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7032a3fd0a71426d338190ec0eeb86f5c547c3dd;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: h1: Don't compare host and authority if only h1 headers are parsed

When only request headers are parsed, the host header should not be compared to
the request authority because no start-line was parsed. Thus there is no
authority.

Till now this bug was hidden because this parsing mode was only used for the
response in the FCGI multiplexer. Since the HTTP checks refactoring, the request
headers may now also be parsed without the start-line.

This patch fixes the issue #610. It must be backported to 2.1.
---

diff --git a/src/h1.c b/src/h1.c
index 7513773c81..53da12a29a 100644
--- a/src/h1.c
+++ b/src/h1.c
@@ -830,7 +830,7 @@ int h1_headers_to_hdr_list(char *start, const char *stop,
 						break;
 					}
 				}
-				else if (!(h1m->flags & H1_MF_RESP) && isteqi(n, ist("host"))) {
+				else if (!(h1m->flags & (H1_MF_HDRS_ONLY|H1_MF_RESP)) && isteqi(n, ist("host"))) {
 					if (host_idx == -1) {
 						struct ist authority;