From: Andreas Schneider <asn@samba.org>
Date: Thu, 7 Aug 2025 11:45:48 +0000 (+0200)
Subject: auth:creds: Keep the password secret
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=705db6c8b295f65f40b7dcd0d5dc0f6db901c8d7;p=thirdparty%2Fsamba.git

auth:creds: Keep the password secret

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15893

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
---

diff --git a/auth/credentials/credentials.c b/auth/credentials/credentials.c
index 1992b1c6a74..1a64a2d8cdc 100644
--- a/auth/credentials/credentials.c
+++ b/auth/credentials/credentials.c
@@ -626,6 +626,7 @@ _PUBLIC_ bool cli_credentials_set_password(struct cli_credentials *cred,
 		if (cred->password == NULL) {
 			return false;
 		}
+		talloc_keep_secret(discard_const(cred->password));
 
 		/* Don't print the actual password in talloc memory dumps */
 		talloc_set_name_const(cred->password,