From: Peter Müller <peter.mueller@ipfire.org>
Date: Fri, 24 Nov 2023 13:37:24 +0000 (+0000)
Subject: Revert "dhcp.cgi: Add column with resolved hostname by IP address"
X-Git-Tag: v2.27-core182~16^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=70d8e3be302cfc30631d7cc5b4f572e410cb777c;p=ipfire-2.x.git

Revert "dhcp.cgi: Add column with resolved hostname by IP address"

This reverts commit ee556e820f02c77716e74be727da319bd429fba4.

See https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/message/QNCXBVG7CNENG4YTSRXXDQCB52E7FEW7/
---

diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
index fdfc74eb4f..84e2322af1 100755
--- a/html/cgi-bin/dhcp.cgi
+++ b/html/cgi-bin/dhcp.cgi
@@ -21,7 +21,6 @@
 
 use strict;
 use experimental 'smartmatch';
-use IO::Socket;
 
 # enable only the following on debugging purpose
 #use warnings;
@@ -1008,9 +1007,8 @@ END
 print <<END
 <table width='100%' class='tbl'>
 <tr>
-    <th width='15%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FETHER'><b>$Lang::tr{'mac address'}</b></a></th>
-    <th width='10%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FIPADDR'><b>$Lang::tr{'ip address'}</b></a></th>
-    <th width='15%' align='center'><b>$Lang::tr{'hostname'}</b></th>
+    <th width='20%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FETHER'><b>$Lang::tr{'mac address'}</b></a></th>
+    <th width='20%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FIPADDR'><b>$Lang::tr{'ip address'}</b></a></th>
     <th width='15%' align='center'><b>$Lang::tr{'remark'}</b></th>
     <th width='15%' class='boldbase' align='center'><b>next-server</b></th>
     <th width='15%' class='boldbase' align='center'><b>filename</b></th>
@@ -1108,14 +1106,9 @@ foreach my $line (@current2) {
 	$TAG4 = "class='red'" if ($dhcpsettings{'KEY2'} ne $key);
     }
 
-	# resolved name (if exists)
-	my $iaddr = inet_aton($temp[1]);
-	my $rname = gethostbyaddr($iaddr, AF_INET);
-	if (!$rname || $rname eq "") { $rname = $Lang::tr{'ptr lookup failed'}; }
     print <<END
 <td align='center' $col>$TAG2$temp[0]$TAG3</td>
 <td align='center' $TAG4 $col>$TAG0$temp[1]$TAG1</td>
-<td align='center' $col>$rname&nbsp;</td>
 <td align='center' $col>$temp[6]&nbsp;</td>
 <td align='center' $col>$temp[3]&nbsp;</td>
 <td align='center' $col>$temp[4]&nbsp;</td>