From: Kito Xu Date: Wed, 9 Jul 2025 03:52:51 +0000 (+0000) Subject: net: appletalk: Fix device refcount leak in atrtr_create() X-Git-Tag: v6.16-rc6~14^2~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=711c80f7d8b163d3ecd463cd96f07230f488e750;p=thirdparty%2Flinux.git net: appletalk: Fix device refcount leak in atrtr_create() When updating an existing route entry in atrtr_create(), the old device reference was not being released before assigning the new device, leading to a device refcount leak. Fix this by calling dev_put() to release the old device reference before holding the new one. Fixes: c7f905f0f6d4 ("[ATALK]: Add missing dev_hold() to atrtr_create().") Signed-off-by: Kito Xu Link: https://patch.msgid.link/tencent_E1A26771CDAB389A0396D1681A90A49E5D09@qq.com Signed-off-by: Jakub Kicinski --- diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 73ea7e67f05a7..30242fe103419 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -576,6 +576,7 @@ static int atrtr_create(struct rtentry *r, struct net_device *devhint) /* Fill in the routing entry */ rt->target = ta->sat_addr; + dev_put(rt->dev); /* Release old device */ dev_hold(devhint); rt->dev = devhint; rt->flags = r->rt_flags;