From: Tom de Vries <tdevries@suse.de>
Date: Fri, 12 Sep 2025 13:04:50 +0000 (+0200)
Subject: [gdb/testsuite, tclint] Fix gdb.server
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=715bac3ba9bea9ab4108f3205255cbf377ddfcdb;p=thirdparty%2Fbinutils-gdb.git

[gdb/testsuite, tclint] Fix gdb.server

Running tclint on the test-cases in gdb.server shows a few problems:
...
connect-with-no-symbol-file.exp:72:1: line has trailing whitespace \
  [trailing-whitespace]
exit-multiple-threads.exp:73:5: expected braced word or word without \
substitutions in argument interpreted as expr [command-args]
extended-remote-restart.exp:73:5: expected braced word or word without \
  substitutions in argument interpreted as expr [command-args]
monitor-exit-quit.exp:73:5: expected braced word or word without \
  substitutions in argument interpreted as expr [command-args]
reconnect-ctrl-c.exp:54:5: expected braced word or word without \
  substitutions in argument interpreted as expr [command-args]
server-exec-info.exp:24:1: expected braced word or word without \
  substitutions in argument interpreted as expr [command-args]
stop-reply-no-thread.exp:73:5: expected braced word or word without \
  substitutions in argument interpreted as expr [command-args]
/stop-reply-no-thread-multi.exp:81:5: expected braced word or word without \
  substitutions in argument interpreted as expr [command-args]
...

Fix these.

Tested on aarch64-linux.
---

diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
index 4e5ee98acf0..01d7e469961 100644
--- a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
+++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
@@ -69,7 +69,7 @@ proc connect_no_symbol_file { sysroot action } {
 	} elseif { $action == "permission" } {
 	  remote_exec target "chmod 000 $target_exec"
 	}
-       
+
 	# Connect to GDBserver.
 	gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
     }
diff --git a/gdb/testsuite/gdb.server/exit-multiple-threads.exp b/gdb/testsuite/gdb.server/exit-multiple-threads.exp
index aae7842bb61..be29f9eeba0 100644
--- a/gdb/testsuite/gdb.server/exit-multiple-threads.exp
+++ b/gdb/testsuite/gdb.server/exit-multiple-threads.exp
@@ -70,7 +70,7 @@ proc prepare_for_test { executable target_executable disable_multi_process } {
     set gdbserver_protocol [lindex $res 0]
     set gdbserver_gdbport [lindex $res 1]
     set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport]
-    if ![gdb_assert {$res == 0} "connect"] {
+    if { ![gdb_assert {$res == 0} "connect"] } {
 	return
     }
 
diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp
index b3c8c72f02f..a5ba53c1d2b 100644
--- a/gdb/testsuite/gdb.server/extended-remote-restart.exp
+++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp
@@ -70,7 +70,7 @@ proc test_reload { do_kill_p follow_child_p } {
     set live_inf_ptn "process $decimal"
     set dead_inf_ptn "<null>"
 
-    if ${follow_child_p} {
+    if { $follow_child_p } {
 	gdb_test_no_output "set follow-fork child"
 	set parent_prefix " "
 	set child_prefix "\\*"
diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite/gdb.server/monitor-exit-quit.exp
index f308c0fedda..74842a07cef 100644
--- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp
+++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp
@@ -70,7 +70,7 @@ gdb_test_multiple "quit" "" {
 
 # Cleanup, as in default_gdb_exit.
 if { $do_cleanup } {
-    if ![is_remote host] {
+    if { ![is_remote host] } {
 	    remote_close host
     }
     unset gdb_spawn_id
diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
index 83869a38345..bcab2de93cd 100644
--- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
+++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
@@ -51,7 +51,7 @@ proc connect_continue_ctrl_c {} {
     global gdbserver_protocol gdbserver_gdbport
 
     set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport]
-    if ![gdb_assert {$res == 0} "connect"] {
+    if { ![gdb_assert {$res == 0} "connect"] } {
 	return
     }
 
diff --git a/gdb/testsuite/gdb.server/server-exec-info.exp b/gdb/testsuite/gdb.server/server-exec-info.exp
index fccf07554a0..007290aeecc 100644
--- a/gdb/testsuite/gdb.server/server-exec-info.exp
+++ b/gdb/testsuite/gdb.server/server-exec-info.exp
@@ -21,7 +21,7 @@ load_lib gdbserver-support.exp
 require allow_gdbserver_tests allow_shlib_tests
 
 standard_testfile server.c
-if [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] {
+if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
index 9ae00922d67..f1c68a53550 100644
--- a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
@@ -78,7 +78,7 @@ proc run_test { target_non_stop disable_feature } {
 	"Support for the 'multiprocess-feature' packet on future remote targets is set to \"off\"."
 
     set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport]
-    if ![gdb_assert {$res == 0} "connect"] {
+    if { ![gdb_assert {$res == 0} "connect"] } {
 	return
     }
 
diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
index b111dd942a7..aa77095b9e7 100644
--- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
@@ -70,7 +70,7 @@ proc run_test { disable_feature target_nonstop } {
     gdb_test_no_output "maint set target-non-stop ${target_nonstop}"
 
     set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport]
-    if ![gdb_assert {$res == 0} "connect"] {
+    if { ![gdb_assert {$res == 0} "connect"] } {
 	return
     }