From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Tue, 30 Apr 2024 23:34:57 +0000 (+0000)
Subject: Optimization: DelayId::compositePosition() copied position ptr (#1799)
X-Git-Tag: SQUID_7_0_1~134
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=71a99cad8b5a705023914c7f81d86e5bf9d2ce08;p=thirdparty%2Fsquid.git

Optimization: DelayId::compositePosition() copied position ptr (#1799)

Detected by Coverity. CID 1529588: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).
---

diff --git a/src/DelayId.cc b/src/DelayId.cc
index 6143ff806f..91acdb1f99 100644
--- a/src/DelayId.cc
+++ b/src/DelayId.cc
@@ -38,7 +38,7 @@ DelayId::~DelayId ()
 {}
 
 void
-DelayId::compositePosition(DelayIdComposite::Pointer newPosition)
+DelayId::compositePosition(const DelayIdComposite::Pointer &newPosition)
 {
     compositeId = newPosition;
 }
diff --git a/src/DelayId.h b/src/DelayId.h
index 12710c2869..0ab2c9d874 100644
--- a/src/DelayId.h
+++ b/src/DelayId.h
@@ -29,7 +29,7 @@ public:
     unsigned short pool() const;
     DelayIdComposite::Pointer compositePosition();
     DelayIdComposite::Pointer const compositePosition() const;
-    void compositePosition(DelayIdComposite::Pointer );
+    void compositePosition(const DelayIdComposite::Pointer &);
     bool operator == (DelayId const &rhs) const;
     operator bool() const;
     int bytesWanted(int min, int max) const;