From: Pawel Baldysiak Date: Tue, 20 Jan 2015 12:52:25 +0000 (+0100) Subject: IMSM: Clear migration record on disks more often X-Git-Tag: mdadm-3.3.3~86 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=71e5411eeaf7e97a67dfed20ea8c365e28c7481c;p=thirdparty%2Fmdadm.git IMSM: Clear migration record on disks more often Migration record is not always cleared after successful migration. This can block another reshape from being started. Migration will not be continued via systemd service due to error in verifying reshape position. This patch added clearing migration record when disk is added to container, and after successful migration. Signed-off-by: Pawel Baldysiak Signed-off-by: NeilBrown --- diff --git a/super-intel.c b/super-intel.c index 4c53019c..4b23b9ab 100644 --- a/super-intel.c +++ b/super-intel.c @@ -5055,6 +5055,14 @@ static int add_to_super_imsm(struct supertype *st, mdu_disk_info_t *dk, } get_dev_size(fd, NULL, &size); + /* clear migr_rec when adding disk to container */ + memset(super->migr_rec_buf, 0, MIGR_REC_BUF_SIZE); + if (lseek64(fd, size - MIGR_REC_POSITION, SEEK_SET) >= 0) { + if (write(fd, super->migr_rec_buf, + MIGR_REC_BUF_SIZE) != MIGR_REC_BUF_SIZE) + perror("Write migr_rec failed"); + } + size /= 512; serialcpy(dd->disk.serial, dd->serial); set_total_blocks(&dd->disk, size); @@ -10648,6 +10656,24 @@ static int imsm_manage_reshape( } + /* clear migr_rec on disks after successful migration */ + struct dl *d; + + memset(super->migr_rec_buf, 0, MIGR_REC_BUF_SIZE); + for (d = super->disks; d; d = d->next) { + if (d->index < 0 || is_failed(&d->disk)) + continue; + unsigned long long dsize; + + get_dev_size(d->fd, NULL, &dsize); + if (lseek64(d->fd, dsize - MIGR_REC_POSITION, + SEEK_SET) >= 0) { + if (write(d->fd, super->migr_rec_buf, + MIGR_REC_BUF_SIZE) != MIGR_REC_BUF_SIZE) + perror("Write migr_rec failed"); + } + } + /* return '1' if done */ ret_val = 1; abort: