From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 11 Apr 2025 11:39:06 +0000 (+0200)
Subject: qemu: block: Don't crash if qemuBlockThrottleFiltersDetach gets NULL @data
X-Git-Tag: v11.3.0-rc1~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=727f42a8cdfae5d2f61d1f6f8b5f2d7765d11c97;p=thirdparty%2Flibvirt.git

qemu: block: Don't crash if qemuBlockThrottleFiltersDetach gets NULL @data

'qemuBlockThrottleFiltersDetach' crashes if @data is NULL. That can
happen in 'qemuDomainAttachDiskGeneric' as it's used as a rollback path
in cases when we didn't yet initialize the filter struct.

Fix it by tolerating NULL @data.

Closes: https://gitlab.com/libvirt/libvirt/-/issues/765
Fixes: 9a6560f066d1e65502d901f32ff2e91ffed3b209
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 27ef1b8375..f0601924ae 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -2875,6 +2875,9 @@ qemuBlockThrottleFiltersDetach(qemuMonitor *mon,
 {
     size_t i;
 
+    if (!data)
+        return;
+
     for (i = data->nfilterdata; i > 0; i--)
         qemuBlockThrottleFilterAttachRollback(mon, data->filterdata[i-1]);
 }