From: Vincent Bernat <bernat@luffy.cx>
Date: Sat, 13 Dec 2008 18:34:05 +0000 (+0100)
Subject: Do not try to set media type network policy since its usefulness is
X-Git-Tag: 0.3~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7286246f5d4307c0cc8eeab3535a48b665afdc4c;p=thirdparty%2Flldpd.git

Do not try to set media type network policy since its usefulness is
near zero when not being able to set it differently on each port.
Those kind of information should be set through SNMP.
---

diff --git a/man/lldpd.8 b/man/lldpd.8
index d2cad2a7..32716e68 100644
--- a/man/lldpd.8
+++ b/man/lldpd.8
@@ -26,7 +26,6 @@
 .Op Fl p Ar probe time
 .Op Fl M Ar class
 .Op Fl L Ar location
-.Op Fl P Ar policy
 .Sh DESCRIPTION
 .Nm
 is a daemon able to receive and send
@@ -209,6 +208,13 @@ where the first digit should be
 .Ar 3
 and the second argument is the ELIN number.
 .El
+.Pp
+Locations set using this option are set for all ports. There is
+currently no way to affect different locations to different
+ports. Using this TLV, network connectivity devices usually advertise
+the location of a class III device. Since it is unlikely that all
+devices are in the same location, the location TLV should be different
+for each port. This is not possible actually.
 .Sh FILES
 .Bl -tag -width "/var/run/lldpd.socketXX" -compact
 .It /var/run/lldpd.socket
diff --git a/src/lldpd.c b/src/lldpd.c
index 2cc3bd6c..44d9b726 100644
--- a/src/lldpd.c
+++ b/src/lldpd.c
@@ -1584,7 +1584,7 @@ main(int argc, char *argv[])
 	int snmp = 0;
 #endif
 	char *mgmtp = NULL;
-	char *popt, opts[] = "vdxm:p:M:iL:P:@                    ";
+	char *popt, opts[] = "vdxm:p:M:iL:@                    ";
 	int probe = 0, i, found, vlan = 0;
 #ifdef ENABLE_LLDPMED
 	int lldpmed = 0, noinventory = 0;
@@ -1624,7 +1624,6 @@ main(int argc, char *argv[])
 			noinventory = 1;
 			break;
 		case 'L':
-		case 'P':
 			/* Handled later */
 			break;
 #else
@@ -1714,8 +1713,6 @@ main(int argc, char *argv[])
 			case 'L':
 				lldpd_parse_location(&cfg->g_lchassis, optarg);
 				break;
-			case 'P':
-				break;
 			}
 		}
 	}