From: Eric Wong <e@80x24.org>
Date: Mon, 11 Nov 2024 21:56:56 +0000 (+0000)
Subject: view: avoid uninitialized var from diff query textarea
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=72aff12ebb50005527f6e4f7800e5f250e47fd70;p=thirdparty%2Fpublic-inbox.git

view: avoid uninitialized var from diff query textarea

Rare commits without titles and emails without a Subject: header
should not litter stderr or syslog with uninitialized variable
warnings.
---

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 275258e3f..7ca85a859 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -849,7 +849,7 @@ sub thread_skel ($$$) {
 sub dfqry_text ($$) {
 	my ($ctx, $subj) = @_;
 	my $qry_dfblob = delete $ctx->{-qry_dfblob} or return (undef);
-	my @bs = split /["\x{201c}\x{201d}]+/, $subj;
+	my @bs = split /["\x{201c}\x{201d}]+/, $subj // '';
 	my $q = join ' ', (@bs ? ('(') : ()), map {
 		chop if length > 7; # include 1 abbrev "older" patches
 		"dfblob:$_";