From: Timo Sirainen <tss@iki.fi>
Date: Thu, 5 Sep 2013 23:39:56 +0000 (+0300)
Subject: Avoid doing side effects in assert.
X-Git-Tag: 2.2.6~110
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=72e15c62aae18da5cd17b7e0c9124d23c06d2587;p=thirdparty%2Fdovecot%2Fcore.git

Avoid doing side effects in assert.
---

diff --git a/src/lib-imap-client/imapc-connection.c b/src/lib-imap-client/imapc-connection.c
index 0276730d40..18c20865cf 100644
--- a/src/lib-imap-client/imapc-connection.c
+++ b/src/lib-imap-client/imapc-connection.c
@@ -1854,7 +1854,8 @@ void imapc_command_sendvf(struct imapc_command *cmd,
 			/* %1s - no quoting */
 			const char *arg = va_arg(args, const char *);
 
-			i_assert(cmd_fmt[++i] == 's');
+			i++;
+			i_assert(cmd_fmt[i] == 's');
 			str_append(cmd->data, arg);
 			break;
 		}