From: oltolm <oleg.tolmatcev@gmail.com>
Date: Sun, 24 Nov 2024 17:39:13 +0000 (+0100)
Subject: gdb/dap: allow some requests when the process is running
X-Git-Tag: gdb-16-branchpoint~105
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7336a8977d81b7b8c00f2e8ccb8a084afb33b19a;p=thirdparty%2Fbinutils-gdb.git

gdb/dap: allow some requests when the process is running

It is impossible to set a breakpoint when the process is running,
which I find annoying. LLDB does not have this restriction. I made
`setBreakpoints` and `breakpointLocations` work when the process is
running. Probably more requests can be changed, but I only need these
two at the moment.

Approved-By: Tom Tromey <tom@tromey.com>
---

diff --git a/gdb/python/lib/gdb/dap/breakpoint.py b/gdb/python/lib/gdb/dap/breakpoint.py
index 15055f21b7b..6adb826d223 100644
--- a/gdb/python/lib/gdb/dap/breakpoint.py
+++ b/gdb/python/lib/gdb/dap/breakpoint.py
@@ -288,7 +288,7 @@ def _rewrite_src_breakpoint(
     }
 
 
-@request("setBreakpoints")
+@request("setBreakpoints", expect_stopped=False)
 @capability("supportsHitConditionalBreakpoints")
 @capability("supportsConditionalBreakpoints")
 @capability("supportsLogPoints")
diff --git a/gdb/python/lib/gdb/dap/locations.py b/gdb/python/lib/gdb/dap/locations.py
index 967322fbeaf..befb7bf2575 100644
--- a/gdb/python/lib/gdb/dap/locations.py
+++ b/gdb/python/lib/gdb/dap/locations.py
@@ -28,7 +28,7 @@ from .startup import exec_mi_and_log
 # This points out that fixing this would be an incompatibility but
 # goes on to propose "if arguments property is missing, debug adapters
 # should return an error".
-@request("breakpointLocations")
+@request("breakpointLocations", expect_stopped=False)
 @capability("supportsBreakpointLocationsRequest")
 def breakpoint_locations(*, source, line: int, endLine: Optional[int] = None, **extra):
     if endLine is None: