From: Ruan Jinjie <ruanjinjie@huawei.com>
Date: Thu, 27 Jul 2023 11:57:26 +0000 (+0800)
Subject: gpio: davinci: Remove redundant dev_err_probe()
X-Git-Tag: v6.6-rc1~164^2~57
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73561d281631630748fd94bca120a79076b52266;p=thirdparty%2Fkernel%2Flinux.git

gpio: davinci: Remove redundant dev_err_probe()

There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index fff510d86e311..8db5717bdabe5 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -236,7 +236,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 	for (i = 0; i < nirq; i++) {
 		chips->irqs[i] = platform_get_irq(pdev, i);
 		if (chips->irqs[i] < 0)
-			return dev_err_probe(dev, chips->irqs[i], "IRQ not populated\n");
+			return chips->irqs[i];
 	}
 
 	chips->chip.label = dev_name(dev);