From: Alan Modra <amodra@gmail.com>
Date: Tue, 28 Jun 2016 09:29:33 +0000 (+0930)
Subject: Invalid read in _bfd_elf_get_symbol_version_string
X-Git-Tag: binutils-2_26_1~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73590ef79194e7e588d4dd1281d0b451fe485fec;p=thirdparty%2Fbinutils-gdb.git

Invalid read in _bfd_elf_get_symbol_version_string

	PR 20304
	* objdump.c (objdump_print_symname): Don't attempt to retrieve
	version info from synthetic symbols.
---

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 81cb7bdd527..2695a55f134 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2016-06-28  Alan Modra  <amodra@gmail.com>
+
+	PR 20304
+	* objdump.c (objdump_print_symname): Don't attempt to retrieve
+	version info from synthetic symbols.
+
 2016-06-13  Alan Modra  <amodra@gmail.com>
 
 	* objcopy.c (copy_main): Init newsym->othersym.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index ba9cd7c5460..c85b0234f18 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -809,7 +809,8 @@ objdump_print_symname (bfd *abfd, struct disassemble_info *inf,
 	name = alloc;
     }
 
-  version_string = bfd_get_symbol_version_string (abfd, sym, &hidden);
+  if ((sym->flags & BSF_SYNTHETIC) == 0)
+    version_string = bfd_get_symbol_version_string (abfd, sym, &hidden);
 
   if (bfd_is_und_section (bfd_get_section (sym)))
     hidden = TRUE;