From: Wouter Wijngaards <wouter@nlnetlabs.nl>
Date: Fri, 3 Jun 2016 07:38:53 +0000 (+0000)
Subject: - Fix to not ignore return value of chown() in daemon startup.
X-Git-Tag: release-1.5.10~112
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=73704e9ed558fc4a84f603f6d97c6fc461169469;p=thirdparty%2Funbound.git

- Fix to not ignore return value of chown() in daemon startup.


git-svn-id: file:///svn/unbound/trunk@3752 be551aaa-1e26-0410-a405-d3ace91eadb9
---

diff --git a/daemon/remote.c b/daemon/remote.c
index 7690ee8b1..7fac32d6b 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -359,8 +359,12 @@ add_open(const char* ip, int nr, struct listen_port** list, int noproto_is_err,
 		if(fd != -1) {
 #ifdef HAVE_CHOWN
 			if (cfg->username && cfg->username[0] &&
-				cfg_uid != (uid_t)-1)
-				chown(ip, cfg_uid, cfg_gid);
+				cfg_uid != (uid_t)-1) {
+				if(chown(ip, cfg_uid, cfg_gid) == -1)
+					log_err("cannot chown %u.%u %s: %s",
+					  (unsigned)cfg_uid, (unsigned)cfg_gid,
+					  ip, strerror(errno));
+			}
 			chmod(ip, (mode_t)(S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP));
 #else
 			(void)cfg;
diff --git a/doc/Changelog b/doc/Changelog
index 62e639ddb..705daf660 100644
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,6 @@
+3 June 2016: Wouter
+	- Fix to not ignore return value of chown() in daemon startup.
+
 2 June 2016: Wouter
 	- Fix libubound for edns optlist feature.
 	- Fix distinction between free and CRYPTO_free in dsa and ecdsa alloc.